[Build] Rename library files if native sources of platform are unchanged #1940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HannesWell
force-pushed
the
selective-native-build
branch
6 times, most recently
from
42c0449 to
20ce19c
Compare
Rust rename the SWT native binary files for unchanged platforms to the new version and only build those whose native sources really changed. Avoiding a rebuild of effectively unchanged binaries has multiple advantages, if only a sub-set of all supported platforms is build: - reduced build times - reduced occupation of precious native agents in Jenkins - increased stability of the build because if a native build-agent for a skipped platforms is unavailable the build isn't blocked. - reduced future growth of the git large-file storage occupation as renaming a binary file has basically zero-cost, while a modified binary (even if just slightly) will add the entire file again.
HannesWell
force-pushed
the
selective-native-build
branch
from
20ce19c to
99243d2
Compare
Member
Author
|
All testing done was successful and the results are as expected. So this is ready for submission. @eclipse-platform/eclipse-platform-committers please pay special attention to the build and not build (respectively just rename) of the native binaries in case you are changing the native sources of one or multiple platforms. Thanks in advance. |
Contributor
|
Thank you, Hannes! Great improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build only the SWT binaries whose native sources are really changed and just rename the binaries for all other platforms that are not changed.
Avoiding a rebuild of effectively unchanged binaries has multiple advantages, if only a sub-set of all supported platforms is build:
In order to ensure that native libraries can be renamed without recompilation, we first require:
This PR uses the same strategy as already used in Equinox:
https://github.com/eclipse-equinox/equinox/blob/master/Jenkinsfile
A visible difference in Jenkins is that, if one triggers a build explicitly, there are now three checkboxes to enforce the rebuild of natives for each supported OS (just like in Equinox).